cache image_ids in NaViT forward pass for group_images mode #355
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When using
group_images=Truewith smallgroup_max_seq_len, theimage_idstensor creation becomes a significant bottleneck. This PR adds LRU caching forimage_idstensors, similar to the existingposemb_gridcache.The Problem
With
group_images=Trueandgroup_max_seq_len=5, processing 512 images creates ~440 groups. Each group calls:The
torch.tensor(patch_counts, device=device)call has significant overhead when called 440 times per forward pass.The Solution
Cache the
image_idstensors by patch count pattern usinglru_cache. Since there are only a few unique patch count patterns (e.g.,(3,),(2, 3),(5,)), the cache is highly effective.Benchmark Results
512 variable-width images (16px tall, 32-80px wide),
group_max_seq_len=5:🤖 Generated with Claude Code