Rollback to module-name import to fix defaults issue

[rajeshdavidbabu]

Why ?

Based on the official docs of sanitize-html we need do the following:

If esModuleInterop=true is not set in your tsconfig.json file, you have to import it with:

import * as sanitizeHtml from 'sanitize-html';

Problem:

• Currently, we use default import (eg: import sanitizeHtml from 'sanitize-html') and the resulting js bundle currently would look for the following, which is wrong I assume :

Fix:

• So a module-name import (* as module-name) would result in the right invocation like the following:

Connected issue
#36

[prathyusha586-0408]

I have used below import statement but still facing the same issue.

[rajeshdavidbabu]

I have used below import statement but still facing the same issue.

Did you make a local build and use that build ?

[prathyusha586-0408]

Local build you mean the sanitize-html installation into the libraries? If so, yes. Using "npm install sanitize-html".

[rajeshdavidbabu]

Afaik, this should work as I tested it locally and also using an npm build.

@lucgagan would be nice to have this in sooner cos the main currently breaks.

[prathyusha586-0408]

Afaik, this should work as I tested it locally and also using an npm build.

@lucgagan would be nice to have this in sooner cos the main currently breaks.

@rajeshdavidbabu , can you help me with the steps how you made the local build of the sanitize-html? bcz still am facing the issue.

[prathyusha586-0408]

Anyone helping me here?

[rajeshdavidbabu]

@prathyusha586-0408 okay this is not yet merged so alternatively you can do the following:

• make this change and

I have used below import statement but still facing the same issue.

yeah are you using the local auto or the auto from npm ?

Go to the file where you use import auto from 'auto-playwright' and change it to import auto from '../<your local path to auto.ts>'

[ictsuzukicerby]

Hi folks,

Wondering if this fix will be merged soon, I am working on a POC and this tool looks very interesting.

Thanks for all your effort!

[seniorQAautomationEngineer]

Please merge the fix, guys. This is blocker for running tests.

[rajeshdavidbabu]

@lucgagan let me know if there is something wrong with this one. If not we have to merge it inorder to unblock users.

[prathyusha586-0408]

@prathyusha586-0408 okay this is not yet merged so alternatively you can do the following:

• make this change and

I have used below import statement but still facing the same issue.

yeah are you using the local auto or the auto from npm ?

Go to the file where you use import auto from 'auto-playwright' and change it to import auto from '../<your local path to auto.ts>'

@rajeshdavidbabu , i have tried as mentioned but getting below error:

[chris-mclennan]

I tried to use auto-playwright but also ran into this issue. What is holding this up?

[stoyanov-x]

@lucgagan When can a new release/npm package version be expected?

[chris-mclennan]

I still can't get this to work out of the box. Like the others, I am getting: TypeError: Cannot read properties of undefined (reading 'defaults')

[tmbridge]

I'm also still getting this error.

[ohlori]

I'm still getting this error too

[laiyee-asm]

I've revert the sanitizeHtml.ts import from import * as sanitizeHtml from 'sanitize-html'; to import sanitize from "sanitize-html";
And, I tested it locally and also using an npm build.

[gregbrandt]

@lucgagan Is this fix going to be release?