Open object for semtypes (#193)

* Open object for semtypes * fix it * insta
lucasavila00 · May 10, 2024 · 9096f72 · 9096f72
1 parent fc38d9b
commit 9096f72
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 3 deletions.
diff --git a/packages/beff-core/src/ast/json_schema.rs b/packages/beff-core/src/ast/json_schema.rs
@@ -245,7 +245,6 @@ impl JsonSchema {
  } else {
  Self::AllOf(BTreeSet::from_iter(vs))
  }
- // Self::AllOf(BTreeSet::from_iter(vs))
  }
  }
  }

diff --git a/packages/beff-core/src/subtyping/mod.rs b/packages/beff-core/src/subtyping/mod.rs
@@ -115,7 +115,7 @@ impl<'a> ToSemTypeConverter<'a> {
  .collect::<Result<_>>()?;
  let rest = match rest {
  Some(r) => self.to_sem_type(r, builder)?,
- None => SemTypeContext::never().into(),
+ None => SemTypeContext::unknown().into(),
  };
  Ok(builder.mapping_definition(Rc::new(vs), rest).into())
  }

diff --git a/packages/beff-core/src/subtyping/to_schema.rs b/packages/beff-core/src/subtyping/to_schema.rs
@@ -184,9 +184,12 @@ impl<'a, 'b> SchemerContext<'a, 'b> {
  }
 
  let rest = if mt.rest.is_empty(self.ctx.0) {
+ panic!("rest should not be empty, all records are open")
+ } else if mt.rest.is_any() {
  None
  } else {
- Some(Box::new(self.convert_to_schema(&mt.rest, None)))
+ let schema = self.convert_to_schema(&mt.rest, None);
+ Some(Box::new(schema))
  };
 
  JsonSchema::Object {