-
Notifications
You must be signed in to change notification settings - Fork 520
Implement read-only/write-only table indexer syntax #2137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
PhoenixWhitefire
wants to merge
12
commits into
luau-lang:master
Choose a base branch
from
PhoenixWhitefire:read-write-indexers
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Implement read-only/write-only table indexer syntax #2137
PhoenixWhitefire
wants to merge
12
commits into
luau-lang:master
from
PhoenixWhitefire:read-write-indexers
+233
−37
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…teOnlyIndexers` flag
Contributor
Author
|
Not finished yet: --!strict
function _foo(x: { read number })
local y: { number } = x
y[1] = 5 -- No Type Error
endEDIT: Fixed, and improved error messages |
I need to fix this bug in 2 different PRs, so I'm flagging it with a non-PR-specific name
Re-add flags I accidentally deleted in the merge
Contributor
Author
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Contributor
Author
|
Need to support different read/write indexers |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.

Additionally adds the
LuauReadWriteOnlyIndexersandLuauLValueCompoundAssignmentVisitLhsflag and 6 new testsThe tests are casting string indexing to
:: stringexplicitly because there seems to be an unrelated bug where string singletons are not checked properlyDefined in RFC https://rfcs.luau.org/syntax-property-access-modifiers.html, https://rfcs.luau.org/property-writeonly.html, https://rfcs.luau.org/property-readonly.html
The
LuauLValueCompoundAssignmentVisitLhswas added to prevent a merge conflict with #2071, which implements the same fix.