Update ua switch #27
Open
Update ua switch #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uaswitch no longer loads (and prevents the browser from starting). This PR updates
luakit-plugins/uaswitchto usemodes.add_cmds,settingsrather thanglobalsand the new_Mstyle modules. (I'm assuming this is in line with #15, but that issue's light on details.)A few things to pay extra attention to (I'm obviously happy to change anything):
-
ua_strings.luareturns its table rather than assigning it (as_Mcan't be seen).- A level of indirection is removed on startup:
load()which just calledload_ua_strings()is removed andload_ua_strings()called directly.- A level of indirection is removed with the default ua handling:
ua_alias_defaultis removed and"default"used explicitly. (As there was no benefit to having a variable.)I also have the (2017 era) list of UAs from #16 staged and ready to commit, if you'd like those included in this. (I assumed since there was a separate issue, a separate PR were appropriate).
I also have an enhancement to call a menu to display known UAs staged and ready to commit.