Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New view "directory" which display all entries in a list with datatables #25

Merged
merged 1 commit into from
Feb 20, 2018

Conversation

proxyconcept
Copy link

Enhancement (can resolve #19) :

  • Add a new menu called "Directory" (with translations)
  • Display all entries in rows and columns
  • Integration of DataTables to sort and paginate
  • Config option $use_directory to enable or disable this view
  • Config options for displayed columns and default sort

@nqb
Copy link
Contributor

nqb commented Feb 15, 2018

There is also a link on each row to display entry (mentioned by @coudot in #16).

Other issues related : #1

@coudot coudot self-requested a review February 20, 2018 14:36
@coudot coudot added this to the 0.2 milestone Feb 20, 2018
Copy link
Member

@coudot coudot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice!

We need to see if we can use the same for advanced search results when we use rows instead of boxes.

@coudot coudot merged commit deb8eb1 into ltb-project:master Feb 20, 2018
@nqb
Copy link
Contributor

nqb commented Feb 20, 2018

Very nice!

Agree with @coudot.

Remarks on this PR :

  • sort icons should be more close than their column name to avoid sorting on bad column name
  • no tel: or mail: links for each row (in comparison with quick/advanced search results)
  • link on each row to display entry : will be nice to have a clickable row rather than an icon. Not so easy because we need to keep tel: and mail: links. Maybe a link on firstname/lastname.
  • generalize display/pagination to quick/advanced search with rows (as @coudot said)
  • number of elements display on pages :
    • add a PHP option to set default number (currently = 10)
    • add additional values in dropdown : "all" and/or an input field to enter a number (for example : 250)
  • print preview is not usuable

@coudot
Copy link
Member

coudot commented Feb 20, 2018

We also need to add documentation on https://ltb-project.org/documentation/white-pages/0.2/start

@nqb could you do it once all required features are done?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display all entries with use_gallery = false
3 participants