Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the comment required feature #191

Merged
merged 1 commit into from
Nov 29, 2024
Merged

Fix the comment required feature #191

merged 1 commit into from
Nov 29, 2024

Conversation

coudot
Copy link
Member

@coudot coudot commented Nov 29, 2024

The "required" parameter was not correctly set:

{if $use_lockcomment_required || $use_unlockcomment_required}required{/if}

This means that if only one of the two options is true, the required field is set.

The required field should be set only if the matching option is true.

@abpai94 feel free to contact me if this is not clear for you.

@coudot coudot merged commit ebc2a13 into master Nov 29, 2024
1 check passed
@coudot coudot deleted the improve-modal-template branch November 29, 2024 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant