Improve sensitivity of last two integration tests #904
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: bbc2 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
bbc2
force-pushed
the
fix-integration-test
branch
from
c25c28c to
e61b419
Compare
Those tests were only checking that the output was nonempty, so they would pretty much never detect anything fishy. We could go further but it's nontrivial because the output is nondeterministic (because of temporary files) and it's unclear if we want to build complex regexes in the test suite right now. In the meantime, here's a basic improvement.
Codecov Report
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. @@ Coverage Diff @@
## master #904 +/- ##
==========================================
- Coverage 86.53% 85.71% -0.82%
==========================================
Files 49 49
Lines 4848 4852 +4
==========================================
- Hits 4195 4159 -36
- Misses 653 693 +40
... and 13 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Those tests were only checking that the output was nonempty, so they would pretty much never detect anything fishy. We could go further but it's nontrivial because the output is nondeterministic (because of temporary files) and it's unclear if we want to build complex regexes in the test suite right now. In the meantime, here's a basic improvement.
TODO
cargo fmtAdd necessary testsAdd changelog entryUpdate default config/theme in README (if applicable)Update man page at lsd/doc/lsd.md (if applicable)