Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow globs to apply to '..' and '.' #848

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

Jackenmen
Copy link

Fixes #847


TODO

  • Use cargo fmt
  • Add necessary tests
  • Add changelog entry
  • Update default config/theme in README (if applicable)
  • Update man page at lsd/doc/lsd.md (if applicable)

@Jackenmen Jackenmen requested review from meain and Peltoche as code owners May 26, 2023 18:11
@muniu-bot
Copy link

muniu-bot bot commented May 26, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: Jackenmen

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@Jackenmen
Copy link
Author

Jackenmen commented May 26, 2023

I manually tested this and it acts about as I would expect it to - . on the ignore-globs only hides ., .. only hides .., and having both on the list hides both.

Let me know if I should add any unit tests for this. I looked at the existing tests in the file I edited and there didn't seem to be any testing anything to do with ignore_globs so I figured it might not be necessary.

@Jackenmen Jackenmen requested a review from zwpaper as a code owner September 25, 2023 23:31
@muniu-bot muniu-bot bot added the size/M label Sep 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: ignore-globs can't be used to hide . and ..
1 participant