- Sponsor
-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(kubernetes): Using the kubernetes API to monitor pods #54
Open
Jacobbrewer1
wants to merge
8
commits into
lrstanley:master
Choose a base branch
from
Jacobbrewer1:feat/scalable-pods
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jacobbrewer1
changed the title
feat(kubernetes):Using the kubernetes API to monitor pods
feat(kubernetes): Using the kubernetes API to monitor pods
Nov 23, 2024
manelpb
suggested changes
Dec 22, 2024
continue | ||
} | ||
|
||
fmt.Println(workerIps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you remove this print
}) | ||
} | ||
|
||
fmt.Println(workerIps) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
here too
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Changes proposed by this PR
I have added the user to configure the application to scout a provided service for pods and automatically update when a pod is killed or deleted. This makes the app a lot more scalable and prevents a redeploy or config change when pods are redeployed; a pods IP can change when a node is updated or re-scaled. This is because the current flow of the app requires the vault endpoints prior to watching them rather than dynamically doing this.
🧰 Type of change
📝 Notes to reviewer
I have added a the Kubernetes GO SDK to talk to the Kubernetes API. All pods will require a service account with the following permissions:
get
onservices
in all namespacesget
onpods
in all namespacesI would have preferred to create a watcher on the vault pods but due to the tight coupling of the apps design, this is not possible without a rewrite.
🤝 Requirements