Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Changes proposed by this PR
This adds more numeric IRC reply constants that I came across while needing two (338 and 378) that were missing.
🧰 Type of change
📝 Notes to reviewer
Constants as specified by https://modern.ircdocs.horse.
I added two constants (
RPL_INVEXLIST
andRPL_ENDOFINVEXLIST
) which are currently the same asRPL_INVITELIST
andRPL_ENDOFINVITELIST
. According to the reference docs the latter two more commonly use 336 and 337, so this is something that might need work. I did not change those as they already present. I also did not sort the constants by value as it seems like the current order was not sorted on purpose.Edit: regarding the invite list, this suggests (to me) that the name might have been an error in the original RFC: "This numeric is sometimes erroneously called RPL_INVITELIST, as this was the name used in RFC2812."
Any questions, please let me know!
🤝 Requirements