Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More numeric IRC reply constants #71

Merged
merged 2 commits into from
Sep 5, 2024
Merged

Conversation

heavyjoost
Copy link
Contributor

@heavyjoost heavyjoost commented Sep 2, 2024

🚀 Changes proposed by this PR

This adds more numeric IRC reply constants that I came across while needing two (338 and 378) that were missing.

🧰 Type of change

  • New feature (non-breaking change which adds functionality).

📝 Notes to reviewer

Constants as specified by https://modern.ircdocs.horse.

I added two constants (RPL_INVEXLIST and RPL_ENDOFINVEXLIST) which are currently the same as RPL_INVITELIST and RPL_ENDOFINVITELIST. According to the reference docs the latter two more commonly use 336 and 337, so this is something that might need work. I did not change those as they already present. I also did not sort the constants by value as it seems like the current order was not sorted on purpose.

Edit: regarding the invite list, this suggests (to me) that the name might have been an error in the original RFC: "This numeric is sometimes erroneously called RPL_INVITELIST, as this was the name used in RFC2812."

Any questions, please let me know!

🤝 Requirements

  • ✍ I have read and agree to this projects Code of Conduct.
  • ✍ I have read and agree to this projects Contribution Guidelines.
  • ✍ I have read and agree to the Developer Certificate of Origin.
  • 🔎 I have performed a self-review of my own changes.
  • 🎨 My changes follow the style guidelines of this project.
  • 💬 My changes as properly commented, primarily for hard-to-understand areas.
  • 📝 I have made corresponding changes to the documentation.
  • 🧪 I have included tests (if necessary) for this change.

Copy link

codecov bot commented Sep 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.95%. Comparing base (80555f2) to head (7bf0e9e).
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master      #71      +/-   ##
==========================================
+ Coverage   53.88%   53.95%   +0.07%     
==========================================
  Files          16       16              
  Lines        2741     2741              
==========================================
+ Hits         1477     1479       +2     
+ Misses       1143     1141       -2     
  Partials      121      121              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrstanley
Copy link
Owner

Edit: regarding the invite list, this suggests (to me) that the name might have been an error in the original RFC: "This numeric is sometimes erroneously called RPL_INVITELIST, as this was the name used in RFC2812."

Honestly, I'm fine if we change it, as I suspect it's a rare reference, and if it's already incorrect, it would be quite odd for someone to be relying on it. Also trust ircdocs.horse.

@heavyjoost
Copy link
Contributor Author

Edit: regarding the invite list, this suggests (to me) that the name might have been an error in the original RFC: "This numeric is sometimes erroneously called RPL_INVITELIST, as this was the name used in RFC2812."

Honestly, I'm fine if we change it, as I suspect it's a rare reference, and if it's already incorrect, it would be quite odd for someone to be relying on it. Also trust ircdocs.horse.

Fixed!

@lrstanley lrstanley merged commit 956b584 into lrstanley:master Sep 5, 2024
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants