Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: only reply to CTCP message if it's not a reply message itself #70

Merged
merged 1 commit into from
Aug 23, 2024

Conversation

heavyjoost
Copy link
Contributor

🚀 Changes proposed by this PR

This fixes some issues I had where it would reply to a CTCP message even though that message was already a reply itself. Normally this probably is not an issue but when using a multiclient bouncer (ZNC in my case), this causes an infinite loop.

🧰 Type of change

  • Bug fix (non-breaking change which fixes an issue).

📝 Notes to reviewer

Basically adds a if ctcp.Reply check just like the CTCP PING/PONG messages already had.

🤝 Requirements

  • 💬 My changes as properly commented, primarily for hard-to-understand areas.
  • 📝 I have made corresponding changes to the documentation.
  • 🧪 I have included tests (if necessary) for this change.

Copy link

codecov bot commented Aug 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 9 lines in your changes missing coverage. Please review.

Project coverage is 53.88%. Comparing base (3842a06) to head (f8f3579).
Report is 5 commits behind head on master.

Files Patch % Lines
ctcp.go 0.00% 8 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   53.75%   53.88%   +0.13%     
==========================================
  Files          16       16              
  Lines        2733     2741       +8     
==========================================
+ Hits         1469     1477       +8     
- Misses       1139     1143       +4     
+ Partials      125      121       -4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@lrstanley
Copy link
Owner

Need to fix my CI flow, but tests LGTM locally.

Thanks!

@lrstanley lrstanley merged commit 80555f2 into lrstanley:master Aug 23, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants