select value bug

[inoas]

No description provided.

[inoas]

Could you approve to see the CI test failure?

[lpil]

Done! The test seems quite large. Is there a smaller reproduction?

[inoas]

@lpil I have added this test because the problem appears for all these types (float, int, string, bool, calendar date) in my tests that I did via cake.

What do you think I should do? Make it 5 tests?
The AS selected_bool ... parts are optional I think I can remove those. They are just to map the numeric placeholders without thinking about it.

[inoas]

I also took a look at the source code bout wouldn't know where to add the conversion from literal values to typed postgres values, this should for now only happen for SELECT I think but there may be other statements that would require the types to be declared?

[lpil]

I don't know what this PR is trying to show so I don't know how to answer the question. Is it 5 bugs specifically relating to those 5 data types?

[inoas]

I don't know what this PR is trying to show so I don't know how to answer the question. Is it 5 bugs specifically relating to those 5 data types?

Yes, all of them will crash currently, each single one.

[lpil]

Can you make minimal reproductions for each bug then please

[lpil]

All the tests passed!

[inoas]

@lpil that was unexpected, also why didn't the combined test then pass?

[inoas]

Please retrigger the CI. It should be red now.

TLDR: oh my... I fiddled around until docker compose + postgres ran locally for pog.
added a unit test with 2 cols... that showed the error.
Then realized by unit test functions do not have _test suffix in the function name, hence the unit tests passed before.

They should not pass anymore.