refactor: parse host, port, and scheme from base_url for credentials #14
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Simplify
credentialconfiguration by accepting a singlebase_urlparameter instead of setting uphost,port, andschememanually by the constructor functionswith_portandwith_scheme.Parsing
base_urlbygleam/urito gethost,port, andscheme:User can now specify a
base_urlinbucket.credentials, andgleam/uriwould automatically parse the URI in the background.