Pass through session token to signer #11
Conversation
| } | ||
|
|
||
| /// Set the session token if credentials given via a task or instance role | ||
| pub fn with_session_token( |
There was a problem hiding this comment.
@lpil I have suggestion for better API. I have to check the session token is present later in the call, and before I use this function (given I can run locally with key/pair or on ECS with token)
Perhaps this can be maybe_with_session_token(option.Option(token)) then it's less code in the caller.
Or just with_session_token(option.Option(...))
No preference with me I already wrote the calling code
There was a problem hiding this comment.
Having it take an option sounds good to me. Let me know if you want me to merge this or wait for that
There was a problem hiding this comment.
ok I change it this afternoon to take option! 👍
There was a problem hiding this comment.
@lpil ready for you. Thanks for quick turnaround
(I take any interface you prefer)
devstopfix
force-pushed
the
pass-through-session-token
branch
from
77e9076 to
e36974f
Compare
2 participants
We run this library inside
ECSand therefore we need to pass the session tokenalong with the key-pair.
This change is in production and has been tested