Fix no such upload test with expired id (#7) #10
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gemini evaluation:
The Old Behavior (Or Slow Failure): Your client started sending the request headers and the data body. S3 took a moment to look up the Upload ID. By the time S3 realized the ID was invalid and sent the 404, your client had likely finished writing the small unit-test payload to the socket. The client then sat waiting for a response, read the 404 gracefully, and reported the XML error.
The New Behavior (Fast Failure): S3 is now rejecting the request immediately—likely because it checks the format of "incorrect" (which is obviously invalid) before it even looks at the database, or simply because the lookup is faster.