[#149] Pipeline - task template #150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Closed
lovit
commented
Feb 4, 2025
|
|
||
|
|
||
| def from_dict(data: dict) -> Config: | ||
| return dacite.from_dict(data_class=Config, data=data) # type: ignore |
There was a problem hiding this comment.
# type: ignore 제거 시 pyright failed
soynlp/soynlp/configs/config.py
soynlp/soynlp/configs/config.py:4:8 - warning: Import "yaml" could not be resolved from source (reportMissingModuleSource)
soynlp/soynlp/configs/config.py:25:53 - error: Argument of type "dict[Unknown, Unknown]" cannot be assigned to parameter "data" of type "Data" in function "from_dict"
"dict[Unknown, Unknown]" is incompatible with protocol "Data"
"keys" is an incompatible type
Type "() -> dict_keys[Unknown, Unknown]" is not assignable to type "() -> None"
Function return type "dict_keys[Unknown, Unknown]" is incompatible with type "None"
"dict_keys[Unknown, Unknown]" is not assignable to "None"
"__getitem__" is an incompatible type
Type "(key: Unknown, /) -> Unknown" is not assignable to type "(item: Unknown) -> None"
Missing keyword parameter "item"
... (reportArgumentType)
1 error, 1 warning, 0 informations
yaml.full_load(file) 가 반환하는 값의 타입이 dict[Unknown, Unknown] 으로 추론되기에 data_class 와 타입 불일치가 일어남. 이후에 해결하기 위해 임시로 pyright 체크 과정을 건너 띔
이로 인해 from_yaml 함수의 line 21 에서도 동일한 오류 발생
lovit
commented
Feb 4, 2025
| for task_config in config.pipeline: | ||
| task_module = importlib.import_module("soynlp.pipeline.tasks") | ||
| task_class: type[Task] = getattr(task_module, f"{task_config.name}Task") | ||
| task_args = dacite.from_dict(data_class=task_class.args(), data=task_config.args) # type: ignore |
There was a problem hiding this comment.
https://github.com/lovit/soynlp/pull/150/files#r1941706190 와 동일한 오류 발생. 임시로 무시함
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve #149