feat(tests): Add more Unit tests #5364
Conversation
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
|
|
||
| const formatted = notification.format(msg); | ||
| assert.ok(formatted.includes("Test Monitor"), "Should include monitor name"); | ||
| assert.ok(formatted.includes("https://test.mydomain.com"), "Should include full URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
| }; | ||
|
|
||
| const maliciousFormatted = notification.format(maliciousMsg); | ||
| assert.ok(!maliciousFormatted.includes("test.mydomain.com"), "Should not include test.mydomain.com as substring"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
|
|
||
| const maliciousFormatted = notification.format(maliciousMsg); | ||
| assert.ok(!maliciousFormatted.includes("test.mydomain.com"), "Should not include test.mydomain.com as substring"); | ||
| assert.ok(maliciousFormatted.includes("https://malicious.mydomain.com"), "Should include exact malicious URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
| }; | ||
| const upFormatted = notification.format(upMsg); | ||
| assert.ok(upFormatted.includes("up"), "Should indicate UP status"); | ||
| assert.ok(upFormatted.includes("https://test1.mydomain.com"), "Should include complete URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
| }; | ||
| const downFormatted = notification.format(downMsg); | ||
| assert.ok(downFormatted.includes("down"), "Should indicate DOWN status"); | ||
| assert.ok(downFormatted.includes("https://test2.mydomain.com"), "Should include complete URL"); |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
|
I don't know why the backend-test failing I found no error in it still fails. Needs to look into it. |
When checking the url, I think you should parse into a URL by using |
Ohh that could work i will look into into it! |
This reverts commit 76ee06a.
Zaid-maker
force-pushed
the
more-tests
branch
from
060cc5b to
030ff79
Compare
…into more-tests
- All DNS record types - Various DNS providers - Edge cases and error conditions - Response format validation - Performance metrics - Security validations
- Better test organization - More comprehensive coverage - Improved error handling - Better async cleanup - More realistic test scenarios
…into more-tests
| } | ||
|
|
||
| // Check for potential URL substring issues | ||
| if (testCase.url.includes("test.mydomain.com")) { |
Check failure
Code scanning / CodeQL
Incomplete URL substring sanitization High test
|
Will pick up this PR soon and complete it. |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Add more Tests tests might get failed
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.