Fix/#359 - Redirect to '/dashboard' on computer when shrinking from '/list' on mobile #5305
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Logorrheique
changed the title
|
@CommanderStorm Gentle ping ^^ |
Ionys320
reviewed
Nov 14, 2024
src/pages/List.vue
Outdated
| watch: { | ||
| "$root.isMobile"(newVal) { | ||
| if (!newVal && this.$route.path === "/list") { | ||
| this.$router.push("/dashboard"); |
There was a problem hiding this comment.
I suggest you tu use replace instead of push. You'll avoid having the /list and the /dashboard in the browser history (you'll instead only have /dashboard).
this.$router.replace({ path: "/new_path" })
Doc: https://router.vuejs.org/guide/essentials/navigation.html#Replace-current-location
src/pages/List.vue
Outdated
| }, | ||
| mounted() { | ||
| if (!this.$root.isMobile && this.$route.path === "/list") { | ||
| this.$router.push("/dashboard"); |
Ionys320
approved these changes
Nov 18, 2024
|
@CommanderStorm Hi, the PR is ready ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
The changes are fixing the issues #359 .
The bug is when a user use the mobile interface and go '/list' then shrinking or switch to computer size, there is a duplication of monitoring component.
I setup a redirection when the user shrink/switch to computer to /dashboard
Fixes #(issue)
#359
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
2024-10-27.11-53-50.mp4