fix: Keep the change to the "Show Clickable Link" checkbox until entire dashboard is saved #5250
+9
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
R-HNF
changed the title
2 tasks
R-HNF
changed the title
CommanderStorm
requested changes
Oct 26, 2024
CommanderStorm
added
the
pr:please address review comments
R-HNF
commented
Oct 28, 2024
| if (this.$parent.editMode && ignoreSendUrl && Object.keys(this.$root.monitorList).length) { | ||
| return this.$root.monitorList[monitor.element.id].type === "http" || this.$root.monitorList[monitor.element.id].type === "keyword" || this.$root.monitorList[monitor.element.id].type === "json-query"; | ||
| } | ||
| return monitor.element.sendUrl && monitor.element.url && monitor.element.url !== "https://" && !this.editMode; |
There was a problem hiding this comment.
remove this.editMode because it's undefined.
| @@ -48,14 +48,11 @@ class Monitor extends BeanModel { | |||
| let obj = { | |||
| id: this.id, | |||
| name: this.name, | |||
| sendUrl: this.sendUrl, | |||
| sendUrl: !!this.sendUrl, | |||
| url: this.url, | |||
There was a problem hiding this comment.
why did you move url up here?
There are cases where we don't want to expose this information
=> currently, this would leak that as far as I can see..
There was a problem hiding this comment.
@CommanderStorm
It's used in showLink(). Should I have not deleted the following after all?
uptime-kuma/server/model/monitor.js
Lines 55 to 57 in 46d8744
Leaving this if-statement causes the issue described in #3794 because when sendUrl is false, the url isn’t sent from database, and the result of showLink() also becomes false.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Send
urlalways because it's used inshowLink()and fix theisClicablestatus.Additional small changes:
isClickAble->isClickable.monitorindata().I confirmed my fix by checking and unchecking the checkbox, and opening and closing the dialog with the following log output.
Fixes #3794
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Please do not use any external image service. Instead, just paste in or drag and drop the image here, and it will be uploaded automatically.