-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: show which children are down for group notifications #5192
base: master
Are you sure you want to change the base?
feat: show which children are down for group notifications #5192
Conversation
Is it a good idea to display the details? Or should it just show the names of the childs? |
I don't think showing the details is helpful. => Let's limit ourselves to a (truncated if too many are down) list of down direct children |
True, that could become too extreme with too many child elements. I just had another idea: We could make it more compact and directly provide the actual names of the monitors that have problems.
Currently the message would be something like:
We could maybe change it so it would look something like:
Maybe in combination with truncate? Or we omit the details completely and just show the whole path to the children failing? The only problem I see in this idea is, that if you have many nested monitors it could take a bit longer to generate the message because its iterating through them. |
Should be possible in one DB-call via a recursive CTE, see #5193 (review) for an example.
I think we can trim out the redundant messaging. What do you think about this? (with a pretty agressive limit of 2 groups/monitors per level for demonstration purposes)
|
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Before if a group fails you just get the message "Child inaccessible".
Now you can see which childs are failing and what their messages are.
Fixes #4258, #3278
Type of change
Please delete any options that are not relevant.
Checklist