Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #5152 (comment)
Did not think about this because only the user can add these injections => why would anyone inject themselves, but better save than sorry.
I did not use any of the two packages, but rather rolled my own version.
execa
seems a bit too heavy for our usecaseshell-escape
is doing something similar as I am doing, but what they are not handling that something like$HOME
which adds the home environment variable or the backticks which executes the shell can also escape the shell.This is the result
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)