-
-
Notifications
You must be signed in to change notification settings - Fork 5.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove modal when navigating back #5165
base: master
Are you sure you want to change the base?
Conversation
when the modal is opened, its sets overflow hidden, remove this style so as to unfreeze it
Do let me kno if other pop ups also needs these life cycle events to be implemented |
i hadnt saved this T_T
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR,
I have left a few questions below, mostly regarding a bit of likely code-duplication.
Feel too hacky and unsafe, as it's utilized dom and added a lot of events. I prefer not to change the current logic. |
hey i have updated the code now, does this make it better.... i am just now relying on beforeUnmount hook to remove the modal |
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
This comment was marked as spam.
It is not recommended to use `len` for empty string test.
refactor: fix check for empty string
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please remove the unrelated changes.
Otherwise this looks good to me
This reverts commit 949198d.
Done removed those changes |
This comment was marked as spam.
This comment was marked as spam.
This comment has been minimized.
This comment has been minimized.
@CommanderStorm when is the earliest possible time u can retake a look in this again |
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma
Tick the checkbox if you understand [x]:
Description
Fixes #5008
Type of change
Please delete any options that are not relevant.
Checklist
Screenshots (if any)
Uptime.Kuma.-.Google.Chrome.2024-10-08.08-27-34.mp4