Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove modal when navigating back #5165

Open
wants to merge 18 commits into
base: master
Choose a base branch
from

Conversation

mohit-nagaraj
Copy link
Contributor

@mohit-nagaraj mohit-nagaraj commented Oct 8, 2024

⚠️⚠️⚠️ Since we do not accept all types of pull requests and do not want to waste your time. Please be sure that you have read pull request rules:
https://github.com/louislam/uptime-kuma/blob/master/CONTRIBUTING.md#can-i-create-a-pull-request-for-uptime-kuma

Tick the checkbox if you understand [x]:

  • I have read and understand the pull request rules.

Description

Fixes #5008

Type of change

Please delete any options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • User interface (UI)

Checklist

  • My code follows the style guidelines of this project
  • I ran ESLint and other linters for modified files
  • I have performed a self-review of my own code and tested it
  • I have commented my code, particularly in hard-to-understand areas (including JSDoc for methods)
  • My changes generates no new warnings
  • My code needed automated testing. I have added them (this is optional task)

Screenshots (if any)

Uptime.Kuma.-.Google.Chrome.2024-10-08.08-27-34.mp4

@mohit-nagaraj
Copy link
Contributor Author

Do let me kno if other pop ups also needs these life cycle events to be implemented

@CommanderStorm CommanderStorm changed the title Fix(app): #5008 Remove modal when navigating back fix: remove modal when navigating back Oct 8, 2024
Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR,

I have left a few questions below, mostly regarding a bit of likely code-duplication.

src/components/CreateGroupDialog.vue Outdated Show resolved Hide resolved
src/components/CreateGroupDialog.vue Outdated Show resolved Hide resolved
src/components/CreateGroupDialog.vue Outdated Show resolved Hide resolved
@CommanderStorm CommanderStorm added area:core issues describing changes to the core of uptime kuma pr:please address review comments this PR needs a bit more work to be mergable labels Oct 8, 2024
@louislam louislam added the question Further information is requested label Oct 8, 2024
@louislam
Copy link
Owner

louislam commented Oct 8, 2024

Feel too hacky and unsafe, as it's utilized dom and added a lot of events. I prefer not to change the current logic.

@mohit-nagaraj
Copy link
Contributor Author

Feel too hacky and unsafe, as it's utilized dom and added a lot of events. I prefer not to change the current logic.

hey i have updated the code now, does this make it better.... i am just now relying on beforeUnmount hook to remove the modal

@mohit-nagaraj

This comment was marked as spam.

@mohit-nagaraj

This comment was marked as spam.

@CommanderStorm CommanderStorm added pr:needs review this PR needs a review by maintainers or other community members and removed pr:please address review comments this PR needs a bit more work to be mergable labels Oct 9, 2024
@mohit-nagaraj

This comment was marked as spam.

Copy link
Collaborator

@CommanderStorm CommanderStorm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the unrelated changes.
Otherwise this looks good to me

.deepsource.toml Outdated Show resolved Hide resolved
extra/healthcheck.go Outdated Show resolved Hide resolved
@mohit-nagaraj
Copy link
Contributor Author

Done removed those changes

@mohit-nagaraj

This comment was marked as spam.

@mohit-nagaraj

This comment has been minimized.

@mohit-nagaraj
Copy link
Contributor Author

@CommanderStorm when is the earliest possible time u can retake a look in this again

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:core issues describing changes to the core of uptime kuma pr:needs review this PR needs a review by maintainers or other community members question Further information is requested
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dashboard: modal not removed when navigating back
3 participants