Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dashboard: modal not removed when navigating back #5008

Open
1 task done
uhthomas opened this issue Aug 11, 2024 · 0 comments Β· May be fixed by #5165
Open
1 task done

dashboard: modal not removed when navigating back #5008

uhthomas opened this issue Aug 11, 2024 · 0 comments Β· May be fixed by #5165
Labels
bug Something isn't working

Comments

@uhthomas
Copy link

πŸ“‘ I have found these related issues/pull requests

I did look but didn't find anything.

πŸ›‘οΈ Security Policy

Description

The modal window is not fully cleaned up / removed when navigating back (via the browser navigation buttons). There is some logic to clean it up, as the dialog disappears.

πŸ‘Ÿ Reproduction steps

Navigate to the dashboard and click "Edit" on any entry.

image

Click something like "Setup Proxy".

image

Navigate back via the browser and observe the window is dark and nothing is clickable.

image

πŸ‘€ Expected behavior

The modal and dialog should be cleared fully.

πŸ˜“ Actual Behavior

The modal hangs around and renders the page unusable until refreshed.

🐻 Uptime-Kuma Version

1.23.13? I think?

πŸ’» Operating System and Arch

N/A

🌐 Browser

Firefox (Linux)

πŸ–₯️ Deployment Environment

N/A - this is the demo site

πŸ“ Relevant log output

No response

@uhthomas uhthomas added the bug Something isn't working label Aug 11, 2024
@mohit-nagaraj mohit-nagaraj linked a pull request Oct 8, 2024 that will close this issue
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant