Fix NUnit3 task on Linux #276
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current nunit3-console versions use "--" as switch separator on both Windows and Linux. Also the --verbose switch has been replaced by --trace=Verbose.
JorisSpriet
suggested changes
Jun 19, 2018
JorisSpriet
reviewed
Jun 19, 2018
|
|
||
| builder.AppendSwitchIfNotNull(c+"trace=", _trace); | ||
| builder.AppendSwitchIfNotNull("--trace=", _trace); |
There was a problem hiding this comment.
Propose to change to:
if(!Verbose) builder.AppendSwitchIfNotNull("--trace=", _trace);
|
@JorisSpriet Good catch. What should happen if a user specifies both Verbose and InternalTrace? |
|
I suggest to make Verbose take precedence. I entered some comment with the
change too - these are my very first steps on GitHub...
In any case, the option is no longer supported in Nunit3 - so maybe also
output a warning if it _is_ used.
Joris.
…On Tue, Jun 19, 2018 at 6:01 PM, Eberhard Beilharz ***@***.*** > wrote:
@JorisSpriet <https://github.com/JorisSpriet> Good catch. What should
happen if a user specifies both Verbose and InternalTrace?
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#276 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AJyu5-6O1qJVyBKRqvCX1cH_oHOlczDBks5t-SBXgaJpZM4SY0XY>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current nunit3-console versions use "--" as switch separator on
both Windows and Linux. Also the --verbose switch has been
replaced by --trace=Verbose.
This change is