Prevent deadlock on connection close and expose connection to the stream context #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Luiz Aoqui <[email protected]>
During an RPC, the generated method blocks until a response is received or the passed context is cancelled, but if the connection is closed while waiting for either event, the method remains blocked. The new generated code also listens for a connection close event, unblocking the method. Signed-off-by: Luiz Aoqui <[email protected]>
Signed-off-by: Luiz Aoqui <[email protected]>
When running in CI, tests can run slower than on local machine, specially when `-race` is used. Bump the timeout used in `TestRPCInvalidConnection` to account for that. Signed-off-by: Luiz Aoqui <[email protected]>
SuperManifolds
previously approved these changes
Nov 7, 2024
There was a problem hiding this comment.
LGTM but now that we've merged in loopholelabs/frisbee-go#183 could you bump frisbe up to 10.2 before merging?
Signed-off-by: Luiz Aoqui <[email protected]>
Good point, bumped! |
SuperManifolds
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update Frisbee and Polyglot to retrieve latest bug fixes (mainly loopholelabs/polyglot#87 and loopholelabs/frisbee-go#180).
Fixes a deadlock bug where, during an RPC, the generated method blocks until a response is received or the passed context is cancelled, but if the connection is closed while waiting for either event, the method remains blocked.
The new generated code also listens for a connection close event, unblocking the method.
It is also useful in some situations to access the raw connection from a stream, so expose via the stream context.