This repository was archived by the owner on Oct 15, 2025. It is now read-only.
Initial impl moved dirtyTracker and volatilityMonitor up #54
+33
−14
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…eation Signed-off-by: Jimmy Moore <[email protected]>
Signed-off-by: Jimmy Moore <[email protected]>
Signed-off-by: Jimmy Moore <[email protected]>
jimmyaxod
force-pushed
the
jamesmoore/arch-218-drafter-should-create-volatilitymonitors-earlier
branch
from
5cf33cc to
439873e
Compare
Contributor
Author
|
Obsolete will be done in #63 |
ShivanshVij
deleted the
jamesmoore/arch-218-drafter-should-create-volatilitymonitors-earlier
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves dirtyTracker and crucially volatilityMonitor up the chain to when devices are created.
Currently volatilityMonitors are not created until a connection is received to migrate, so Silo doesn't have a good picture of what order to migrate devices. This PR should fix that.