[Feature] Add global tolerations support to sub-charts #607
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Copilot reviewed 2 out of 6 changed files in this pull request and generated 1 comment.
Files not reviewed (4)
- charts/logzio-apm-collector/templates/_pod-spm.tpl: Language not supported
- charts/logzio-apm-collector/templates/_pod.tpl: Language not supported
- charts/logzio-logs-collector/templates/_pod.tpl: Language not supported
- charts/logzio-telemetry/templates/_pod.tpl: Language not supported
Comments suppressed due to low confidence (1)
charts/fluentd/templates/daemonset.yaml:40
- Using 'append' to merge two lists may lead to unintended nesting. Ensure that the global and daemonset tolerations are properly concatenated using a method that flattens the lists.
{{- toYaml (append $globalTolerations $chartTolerations) | indent 8 }}
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
8naama
reviewed
Apr 9, 2025
Contributor
8naama
left a comment
8naama
left a comment
There was a problem hiding this comment.
Looks good! 🎉
Left a bit of questions
This reverts commit 644c813.
8naama
approved these changes
Apr 9, 2025
This reverts commit 4bce85a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
logzio-monitoringsub-chartsk8s-eventsandtrivyWhat type of PR is this?
(check all applicable)
Added tests?