fix(account): use replace instead of assign to prevent back button issue #8151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use window.location.replace instead of window.location.assign when redirecting after sign-in callback. This prevents the code parameter URL from remaining in browser history, which would cause issues when users click the back button.
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/account/src/Callback.tsx | 📈 +2 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
window.location.replaceinstead ofwindow.location.assignwhen redirecting after sign-in callbackProblem
When users sign in to account center:
/account(not authenticated)/account?code=xxx/accountThe issue was that
window.location.assignadds a new entry to browser history, leaving/account?code=xxxin the history. When users click the back button, they return to this expired code URL and get stuck.Solution
Using
window.location.replaceinstead replaces the current history entry, so the code URL is not preserved in browser history.Test plan