feat(account): show specific error when passkey already registered #8149
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Handle WebAuthn error codes in passkey binding flow to show more specific error messages instead of generic "Failed to create" message. - Show "passkey already registered" error when authenticator is already registered to the account - Silently handle user cancellation (ERROR_CEREMONY_ABORTED)
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/account/src/pages/PasskeyBinding/index.tsx | 📈 +501 Bytes |
| packages/phrases-experience/src/locales/ar/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/de/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/en/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/es/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/fr/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/it/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/ja/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/ko/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/pl-pl/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/pt-br/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/pt-pt/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/ru/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/th/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/tr-tr/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/uk-ua/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/zh-cn/account-center.ts | 📈 +102 Bytes |
| packages/phrases-experience/src/locales/zh-hk/account-center.ts | 📈 +131 Bytes |
| packages/phrases-experience/src/locales/zh-tw/account-center.ts | 📈 +131 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
ERROR_AUTHENTICATOR_PREVIOUSLY_REGISTEREDis returnedERROR_CEREMONY_ABORTED) without showing error toastpasskey_already_registeredtranslation key to all 18 localesTest plan