fix(phrases): remove span tags from resend_countdown translations #8147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `DynamicT` component in account center doesn't parse HTML tags, causing `<span>` tags to be displayed as literal text in the verification code countdown message.
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/phrases-experience/src/locales/ar/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/de/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/en/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/es/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/fr/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/it/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/ja/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/ko/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/pl-pl/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/pt-br/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/pt-pt/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/ru/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/th/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/tr-tr/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/uk-ua/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/zh-cn/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/zh-hk/account-center.ts | 📉 -39 Bytes |
| packages/phrases-experience/src/locales/zh-tw/account-center.ts | 📉 -39 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed incorrect display of
<span>tags in account center verification code countdown message.Problem
The
DynamicTcomponent used in the account center doesn't parse HTML tags - it only renders text. This caused<span>and</span>to be displayed as literal text in the countdown message (e.g., "Not received yet? Resend after 58s.").Solution
Removed unnecessary
<span>tags from allresend_countdowntranslation strings across 18 language files.Files changed
account-center.tsfiles inpackages/phrases-experience/src/locales/*/Test plan