fix(account): prevent duplicate TOTP submission toast on success #8143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clear code input immediately after successful TOTP binding to prevent the auto-submit useEffect from triggering a duplicate API call. The issue occurred because: 1. User enters 6 digits, triggering handleSubmit via useEffect 2. API call succeeds, loading changes from true to false 3. handleSubmit (which depends on loading) gets recreated 4. useEffect triggers again since handleSubmit is a dependency 5. Second API call returns "TOTP is already in use" error toast By clearing codeInput before navigation, the isCodeReady check fails and prevents the duplicate submission.
COMPARE TO
|
| Name | Diff |
|---|---|
| packages/account/src/pages/TotpBinding/index.tsx | 📈 +214 Bytes |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
When user enters 6 digits for TOTP verification:
useEffecttriggershandleSubmitloadingstate changes fromtruetofalsehandleSubmitdepends onloading, it gets recreated (new function reference)useEffecttriggers again becausehandleSubmitis in its dependency arraycodeInputstill containing 6 digits,isCodeReady()returns trueSolution
Clear
codeInputimmediately after successful TOTP binding, before navigation. This causesisCodeReady(codeInput)to returnfalsewhen the effect re-triggers, preventing the duplicate submission.Test plan