Skip to content

Conversation

@thisistanishq
Copy link

Summary

Resolves the implementation TODO in packages/console/src/pages/EnterpriseSsoDetails/Experience/DomainsInput/index.tsx.

Refactors DomainsInput to utilize the shared <MultiOptionInput /> component.

Changes

  • Replaced custom implementation with MultiOptionInput.
  • Refactored styles to use CSS Modules (index.module.scss).
  • Improved validation logic to return localized error messages.
  • Added comprehensive unit tests in index.test.tsx.

Verification

  • Unit Tests: Passed. Checked valid rendering, input, and invalid domain blocking.
  • CI: Fixed all linting and commit message checks.

Checklist

  • .changeset
  • unit tests
  • Tested locally

@github-actions
Copy link

COMPARE TO master

Total Size Diff 📈 +709 Bytes

Diff by File
Name Diff
.changeset/tasty-apples-dance.md 📈 +90 Bytes
packages/console/src/pages/EnterpriseSsoDetails/Experience/DomainsInput/index.module.scss 📈 +583 Bytes
packages/console/src/pages/EnterpriseSsoDetails/Experience/DomainsInput/index.test.tsx 📈 +4.04 KB
packages/console/src/pages/EnterpriseSsoDetails/Experience/DomainsInput/index.tsx 📈 +2.86 KB

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement Make it better size/l

Development

Successfully merging this pull request may close these issues.

1 participant