-
Notifications
You must be signed in to change notification settings - Fork 980
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add patterns for some message IDs #201
base: main
Are you sure you want to change the base?
Conversation
- Add action Ignoring - Add CISCO_MESSAGE_ID pattern - Add pattern for message ID 714202
It is difficult for me to evaluate this change because there are no tests available to verify it. If you added tests for the new behavior, I could more easily evaluate the change. |
What kind of test can I provide? Would some sample logs be good enough? The patterns have been tested on https://grokdebug.herokuapp.com/ and live system. On live system, I monitor the message ID and make sure there's no _grokparsefailure tag. The patterns were somewhat derived from the given format on http://www.cisco.com/c/en/us/td/docs/security/asa/syslog-guide/syslogs.html. |
@anhlqn yes, a few log line examples would make it more explicit on what kind of lines these patterns would match. This serves both the purpose of confirming the lines match but also provide documentation. there are many examples in the spec files you can reuse, like https://github.com/logstash-plugins/logstash-patterns-core/blob/master/spec/patterns/firewalls_spec.rb#L84-L101 |
These message IDs follow only one format, so I think one log example should be enough. CISCOFW713202
CISCOFW750006
CISCOFW402116
CISCOFW113009
CISCOFW605005
|
message_id
. Havingmessage_id
field allows us to group events together, and we can also use dictionary filter plugin to add Cisco recommended actions based on this field.If possible, I also want to update existing Cisco patterns to extract this
message_id
field. Cisco syslog is quite helpful for me to troubleshoot network issues.