Add support for arguments when declaring an exchange #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI failure is due to dependency to another pull request on logstash-mixin-rabbitmq_connection project |
|
Added missing mail to CLA. Apologies for the delay (hadn't realized the exact mail was showing in your mail, wrongly assumed the linked mail was another one) |
jordansissel
suggested changes
Mar 24, 2017
| @@ -36,9 +36,12 @@ class RabbitMQ < LogStash::Outputs::Base | |||
| # Should RabbitMQ persist messages to disk? | |||
| config :persistent, :validate => :boolean, :default => true | |||
|
|
|||
| # Additional arguments for the exchange, for example could be the presence of an alternate exchange, ... | |||
There was a problem hiding this comment.
Conflict here -- the :validate => :array doesn't match up with your default value (a hash).
Also, the documentation for this setting isn't quite enough. Can you detail why a user would want to set this?
Is "arguments" the right word? It feels like it is not specific enough of a word.
Original pull request dates, making sure we take comments into account based on latest version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to Logstash! If you haven't already signed our CLA, here's a handy link: https://www.elastic.co/contributor-agreement/