-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
declare deprecation of enterprise search plugin #22
base: main
Are you sure you want to change the base?
Conversation
…oved from Elastic Stack in version 9
log_message = "The App Search product is deprecated and excluded from the version 9 of the Elastic Stack. " + | ||
"This plugin is deprecated and will only receive security updates and critical bug fixes. " + | ||
"We recommend transitioning to our native Elasticsearch tools. " + | ||
"For more details, please visit https://www.elastic.co/guide/en/enterprise-search/current/app-search-workplace-search.html" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@flexitrev same question here about the link https://www.elastic.co/guide/en/enterprise-search/current/app-search-workplace-search.html
The instruction is a bit vague to me
"This plugin is deprecated and will only receive security updates and critical bug fixes. " + | ||
"We recommend transitioning to our native Elasticsearch tools. " + | ||
"For more details, please visit https://www.elastic.co/guide/en/enterprise-search/current/app-search-workplace-search.html" | ||
@deprecation_logger.deprecated log_message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deprecation_logger.deprecated log_message | |
deprecation_logger.deprecated log_message |
Is using an instance variable here an old pattern? https://github.com/logstash-plugins/logstash-mixin-deprecation_logger_support/blob/main/lib/logstash/plugin_mixins/deprecation_logger_support/legacy_init_adapter.rb
"This plugin is deprecated and will only receive security updates and critical bug fixes. " + | ||
"We recommend transitioning to our native Elasticsearch tools. " + | ||
"For more details, please visit https://www.elastic.co/guide/en/enterprise-search/current/app-search-workplace-search.html" | ||
@deprecation_logger.deprecated log_message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deprecation_logger.deprecated log_message | |
deprecation_logger.deprecated log_message |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I think the 3.x series of this plugin will be going in to 9.x for LS and 2.x -> 8.x. Do we need the deprecation log in the 2 series as well? Or does this only apply to removal in the 9.x?
@donoghuc Thanks for the reviews. We maintain a single series of plugin. 3.0.0 is included in 8.17. |
Ah, sorry I confused this with some of the other plugins i've been working on. Thanks that makes sense! 🙃 ERRTOOMANYPLUGINS |
The Enterprise Search product is deprecated and will not be included in the Elastic Stack 9.x release.
As a result, the App Search and Workplace Search plugins are also deprecated. These plugins will only receive security updates and critical bug fixes moving forward.
This commit added deprecation log
fixes: #20, #21