Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactored code #27

Closed
wants to merge 2 commits into from
Closed

Conversation

ALLENGJOSE
Copy link
Contributor

Fixed issue #4 .I implemented Using one push with 2 objects instead.

@ravut8
Copy link
Contributor

ravut8 commented Oct 6, 2023

Hey @ALLENGJOSE, thanks for the PR on issue 4. Just one minor adjustment. Could you create a new branch (refactor/4-update-push-element-in-test-case) and push the "Refactored code" to the new branch? Then, submit another pull request. Currently, there are two commits from two separate PRs.

If you are ok with this, I will go ahead and close this PR. Thanks again 🙏

@ALLENGJOSE
Copy link
Contributor Author

how do I push "Refactored code" to the new branch? Sorry , but I am new to open source. I would be grateful if you could tell me how to do it?

@ravut8
Copy link
Contributor

ravut8 commented Oct 6, 2023

No worries @ALLENGJOSE , here are the summarized steps:

  1. Create a new branch - refactor/4-update-push-element-in-test-case
  2. Make changes to the new branch
  3. Commit your changes

Note: Unfortunately, for commit 3cf3cc7, you will need to redo and commit to the new branch.

@ALLENGJOSE ALLENGJOSE closed this Oct 6, 2023
@ravut8
Copy link
Contributor

ravut8 commented Oct 6, 2023

Hey @ALLENGJOSE, almost there!

I notice that there are many commits in PR #30. Unfortunately, I cannot accept the PR because it will merge all commits into the Berryjam's main. To solve this issue, you could either delete this branch and create another branch OR just create another branch and select main as source. After that, redo the refactored code.

Select Main Source

Note: If you wish to create another branch you can use "refactor/4-update-push-element-in-test"

P.S. Please apply this concept to the rest of your PRs 🙏

@ALLENGJOSE
Copy link
Contributor Author

Thank you for the cooperation. What I am doing is deleting all branches and redoing this all over again. Please bear with me . I want to get this done

@ALLENGJOSE ALLENGJOSE closed this Oct 6, 2023
@ALLENGJOSE ALLENGJOSE deleted the refactor-code branch October 6, 2023 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants