Idfix #38
Open
Idfix #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the flurry of PRs. I'll need to update the travis file unless you can fix the .travis in a new PR. Also since these changes require Facter with structured facts we need to communicate that in the readme and metadata file. We should be targeting Puppet 4.x+ anyways. Please create a CHANGELOG.md and CONTRIBUTORS.md. Add your fixes to Changelog and throw your name/email in the CONTRIBUTORS file. |
|
I've updated the I can create the changelog and contributors files, should we target v 1.0 and support Puppet 4.x+ without or without older versions? |
|
Please target a 1.0 release |
|
We can also target ruby 2.1.9 and ruby 2.4.3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#35 allow setting the user id over the resource.
and workaround the issue with empty usernames & the default anonymous user (be careful here!)