-
Notifications
You must be signed in to change notification settings - Fork 354
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Chrome cache payloads #4696
base: main
Are you sure you want to change the base?
Chrome cache payloads #4696
Conversation
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4696 +/- ##
==========================================
- Coverage 86.12% 86.01% -0.12%
==========================================
Files 416 416
Lines 37446 37344 -102
==========================================
- Hits 32252 32123 -129
- Misses 5194 5221 +27
☔ View full report in Codecov by Sentry. |
@chb2mn must have missed this earlier, looks like this PR has a merge conflict |
7a19acc
to
d708c55
Compare
One line description of pull request
Chrome:cache:entry events only consist of url + time. I wanted to add some richness to that
Description:
I wanted to include some information about the actual payload in the cache. So this includes human-readable information about the datastream(s) behind an entry. The data streams are either internal (
data_N (offset: 0x123456)
) or external (f_012345
).Notes:
@joachimmetz I wanted your opinion on how to format the payload. Right now it's just a
json.dumps(my_list)
, but there's probably a more elegant way of adding the info to the event.Checklist: