fix(chart): allow not specifying resourceQuota quotas and limitRange resources #2074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
|
@JuniorJPDJ thanks for the PR! Not sure if it makes sense to just comment these out, maybe we can introduce an option or new field that allows you to override all other values similar to what we have with roles? |
|
IMO this doesn't make sense as it's just config showcase / default value, which by the way is disabled by default. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)Allows not setting limits and resources in resourceQuota and limitRange. It's impossible to unset some of those values when the default values are specified. If using Umbrella Chart even
nulldoesn't work. This makes it possible to specify only part of those values and set it to own.Please provide a short message that should be published in the vcluster release notes
Allows not setting some of limits and resources in resourceQuota and limitRange.
What else do we need to know?