fix: resource already exists #1785
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vcluster-docs canceled.Built without sensitive environment variables
|
During syncing of virtual namespaces to physical, the default service account already exists, which leads to errors during syncing. In this fix we consume the error in case the physical resource already exists. Co-authored-by: Ajith Chandran <[email protected]> Co-authored-by: Wojtek Koronski <[email protected]>
imkira
force-pushed
the
agora-fix-already-exists-service-account
branch
from
e1d7d3d
to
07b39e7
Compare
|
@heiko-braun there's also this one which I rebased. PTAL cheers. |
zerbitx
reviewed
Sep 3, 2024
| @@ -80,6 +80,10 @@ func (n *namespacedTranslator) SyncToHostCreate(ctx *context.SyncContext, vObj, | |||
| ctx.Log.Debugf("error syncing %s %s/%s to physical cluster: %v", n.name, vObj.GetNamespace(), vObj.GetName(), err) | |||
| return ctrl.Result{RequeueAfter: time.Second}, nil | |||
| } | |||
| if kerrors.IsAlreadyExists(err) { | |||
| ctx.Log.Debugf("ignoring syncing %s %s/%s to physical cluster as it already exists", n.name, vObj.GetNamespace(), vObj.GetName()) | |||
There was a problem hiding this comment.
Beyond a need to update this PR again with the new generics code, I'll have to give this some thought. It has essentially moved to here but placing it in such a central place means that any resource trying to create on sync that already exists could take over the original object and start making changes to it. It might be better to let it fail here as its already doing, or put checks on specific resources like the service accounts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What issue type does this pull request address? (keep at least one, remove the others)
/kind bugfix
What does this pull request do? Which issues does it resolve? (use
resolves #<issue_number>if possible)During syncing of virtual namespaces to physical, the default service account already exists, which leads to errors during syncing. In this fix we consume the error in case the physical resource already exists.
Please provide a short message that should be published in the vcluster release notes
Fixed an issue where vcluster would not sync due to already existing default service accounts
What else do we need to know?
This is part of a collaborative work at Woven by Toyota with my colleagues @ajithcnambiar and @tauxi