Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pin poetry-core version to <2.0.0 in pyproject.toml #3025

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

mgor
Copy link
Contributor

@mgor mgor commented Jan 8, 2025

got back from christmas vacation and rebuilt our framework that uses locust as a library for the first time, and running it failed:

master-1  |     from locust.event import EventHook
master-1  |   File "/venv/lib/python3.12/site-packages/locust/__init__.py", line 24, in <module>
master-1  |     from ._version import version as __version__
master-1  | ModuleNotFoundError: No module named 'locust._version'

scratching my head abit, but realised it thought it was probably related to poetry-dynamic-versioning, so saw that there had been a new release 2025-01-04, but in pyproject.toml this has been pinned with <2.0.0, but poetry-core had a broader constraint and a 2.x version had been released 2025-01-04 as well.

looking through the commit history I found:
81116b2 - Pin Poetry verison in one more place.
fcb6104 - Pin Poetry to 1.x

adding a <2.0.0 constraint in pyproject.toml for poetry-core solved the issue when using locust as a library.

@cyberw cyberw merged commit 41294f8 into locustio:master Jan 8, 2025
17 checks passed
@cyberw
Copy link
Collaborator

cyberw commented Jan 8, 2025

thx! Pinning the version felt kinda bad but long term I want us to switch to uv anyway, so I didnt feel like changing anything for Poetry 2.0 compatibility...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants