Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tic #111

Merged
merged 61 commits into from
Feb 5, 2019
Merged

tic #111

merged 61 commits into from
Feb 5, 2019

Conversation

maelle
Copy link
Contributor

@maelle maelle commented Jan 16, 2019

Expected to address #4 #5 #85

What's missing are the custom tic.R templates for training, analysis and basic projects.

  • not sure what should be in a basic project tic.R

  • in training and analysis the idea will "simply" be to knit things from a folder and store them somewhere (that folder? a branch?) but I'm stuck because the directories can be set by the user, so it's hard to know which one has the Rmd to knit. Thoughts @stephlocke?

@codecov-io
Copy link

codecov-io commented Jan 16, 2019

Codecov Report

❗ No coverage uploaded for pull request base (master@3432d2e). Click here to learn what that means.
The diff coverage is 30.37%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #111   +/-   ##
=========================================
  Coverage          ?   57.32%           
=========================================
  Files             ?       12           
  Lines             ?      635           
  Branches          ?        0           
=========================================
  Hits              ?      364           
  Misses            ?      271           
  Partials          ?        0
Impacted Files Coverage Δ
R/github.R 32.65% <0%> (ø)
R/external_setup.R 0% <0%> (ø)
R/utils.R 49.29% <100%> (ø)
R/use_readme.R 100% <100%> (ø)
R/createPackageProject.R 83.69% <57.14%> (ø)
R/createBasicProject.R 82.53% <72.72%> (ø)
R/createTrainingProject.R 96.59% <80%> (ø)
R/createAnalysisProject.R 96.87% <80%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3432d2e...191e910. Read the comment docs.

@maelle maelle requested a review from stephlocke January 24, 2019 14:12
@maelle
Copy link
Contributor Author

maelle commented Jan 24, 2019

Maybe the dirs could be less flexible, i.e. having analysis, data and outputs by default, and using the dirs arguments only for creating supplemental directories?

@maelle
Copy link
Contributor Author

maelle commented Feb 4, 2019

@stephlocke current questions

  • What folder to knit reports of for training projects?

  • I've added the tic.R for analysis projects. I haven't added conditions on folders present because if there's no "analysis" folder then there's no report there so nothing happens. tic.R has comments. Is this fine? (and the name of the output directory is not important, it could be called anything, even if it does not exist things get deployed to gh-pages, I've just tried that)

@maelle
Copy link
Contributor Author

maelle commented Feb 4, 2019

@stephlocke
Copy link
Member

@stephlocke in createTrainingProject default folders are data, handouts, slides. Which one(s) would you assume contain stuff to knit? "slides" only or "handouts" too?

both - different render types tho

@stephlocke
Copy link
Member

  • I've added the tic.R for analysis projects. I haven't added conditions on folders present because if there's no "analysis" folder then there's no report there so nothing happens. tic.R has comments. Is this fine? (and the name of the output directory is not important, it could be called anything, even if it does not exist things get deployed to gh-pages, I've just tried that)

Looks fine to me

@maelle
Copy link
Contributor Author

maelle commented Feb 4, 2019

I think rmarkdown::render Will automatically render the right format based on YAML info. Will finalize this PR tomorrow 🎉

@maelle maelle merged commit 54e786e into master Feb 5, 2019
@maelle maelle deleted the tic2 branch February 5, 2019 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants