Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cannot "add entry" to reference list #442

Open
LauraErhard opened this issue Dec 12, 2018 · 8 comments
Open

Cannot "add entry" to reference list #442

LauraErhard opened this issue Dec 12, 2018 · 8 comments
Labels
back-end This issue needs to be addressed by the back-end. bug The issue reports a bug.

Comments

@LauraErhard
Copy link

I just tried to add another entry to a reference list and I see this after clicking add entry:
addentry
This can't be right. I would expect that I only get the second form.

I don't know if the 400 error that follows my submit is a consequential error of the first problem but here is the error:

Error creating entry 
Object { headers: {…}, status: 400, statusText: "Bad Request", url: "https://locdb.bib.uni-mannheim.de/locdb/bibliographicEntries?bibliographicResourceId=5a2175daa2bb9026f446e2bb", ok: false, name: "HttpErrorResponse", message: "Http failure response for https://locdb.bib.uni-mannheim.de/locdb/bibliographicEntries?bibliographicResourceId=5a2175daa2bb9026f446e2bb: 400 Bad Request", error: {…} }
@lgalke lgalke added the bug The issue reports a bug. label Dec 12, 2018
@chah3d
Copy link
Collaborator

chah3d commented Dec 27, 2018

The double form is fixed for the next version.
The creation of a new entry on the post bibliographicEntry interface still raises a validation error.
selection_029
(Resource id/Query string: 5bc6f1700e466f16dff1c0b7)
It seems like the validation of the Entry ID (according to the pattern) fails because it does not exist. Are there other attributes that are mandatory for the creation of a new entry, so we can catch faulty entries before transmission? (At the moment even an empty entry can be created which may be of limited use)

@LauraErhard
Copy link
Author

LauraErhard commented Jan 10, 2019

Should I see any changes yet in any of our systems? The only thing I see is in the dev version I still get the double form and strange additional text at the beginning of the page:
unbenannt
EDIT: I just noticed that the additional text is at the beginning of every edit form/page not just the add new entry to reference list edit page.

@lgalke
Copy link
Member

lgalke commented Jan 10, 2019

@chah3d does it make sense to deploy a new version on dev | on prod? @abdelqader-mohammad I could do it you want me to.

@abdelqader-mohammad
Copy link

I can't see the unwanted text at the beginning. I have two forms (one for Edit and the other for Create).

image
image

@lgalke you can do it, please

@lgalke
Copy link
Member

lgalke commented Jan 10, 2019

I pushed a fix and deployed it on dev and prod. @abdelqader-mohammad the debug information was only shown at dev endpoint. I also now disabled it, there.

@lgalke
Copy link
Member

lgalke commented Jan 10, 2019

2416ed4

@LauraErhard
Copy link
Author

LauraErhard commented Jan 10, 2019

Thanks for your quick work, everything looks good now.

But I can't submit the new entry, I always get the following error:

Error creating entry
Object { headers: {…}, status: 400, statusText: "Bad Request", url: "https://locdb.bib.uni-mannheim.de/locdb/bibliographicEntries?bibliographicResourceId=5a548f95fcaa4703f0194ec1", ok: false, name: "HttpErrorResponse", message: "Http failure response for https://locdb.bib.uni-mannheim.de/locdb/bibliographicEntries?bibliographicResourceId=5a548f95fcaa4703f0194ec1: 400 Bad Request", error: {…} }

EDIT: I only filled out the category "raw text", are there any mandatory fields I should have filled out?

@lgalke
Copy link
Member

lgalke commented Jan 10, 2019

We call the entry.create service from the backend. Inspecting the error message, it is caused by a spurious validation check that enforces the 'references' field to be filled with some id.

See the screenshot:
image

Of course that should not happen at that point, @anlausch needs to tackle this.

@lgalke lgalke added back-end This issue needs to be addressed by the back-end. and removed testing labels Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
back-end This issue needs to be addressed by the back-end. bug The issue reports a bug.
Projects
None yet
Development

No branches or pull requests

4 participants