Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Entries in electronic resources (prod) #444

Open
LauraErhard opened this issue Feb 12, 2019 · 14 comments
Open

Entries in electronic resources (prod) #444

LauraErhard opened this issue Feb 12, 2019 · 14 comments

Comments

@LauraErhard
Copy link

Today I noticed, that there are a lot of new entries in the electronic resource list, e.g.:
2019-02-12
Is there a problem with the external / valid settings again?
I don't know if there is any correlation but yesterday we set a few journal articles to Done, but I think some of these entries were already there the day before that.
@abdelqader-mohammad would you please check these entries out.

abdelqader-mohammad pushed a commit that referenced this issue Feb 12, 2019
@lgalke
Copy link
Member

lgalke commented Feb 12, 2019

Deployed including the fix 892c33e on dev. As there were other recent updates, please make sure that dev is running properly before we push the changes to production.

@LauraErhard
Copy link
Author

LauraErhard commented Feb 14, 2019

I'm testing everything on dev right now. While editing the boxes in the scan view I can't delete more than one box at a time. If I do, I get a 500 internal server error. Adding and adjusting more than one box is very smooth and I didn't run into problems there.
EDIT: The first box I deleted is really deleted and every box after that gets a 500 internal server error.

@lgalke
Copy link
Member

lgalke commented Feb 14, 2019

Thanks @LauraErhard , CC @chah3d could you have a look regarding the deletion please?

@chah3d
Copy link
Collaborator

chah3d commented Feb 14, 2019

As far as i could test it, processing the delete requests asynchronously does the trick (accf571). If they still fail there will be a few retries.

@LauraErhard
Copy link
Author

Thanks for your quick work!

@abdelqader-mohammad
Copy link

Thank you for your quick response and help, @lgalke and @chah3d.
@LauraErhard can you test the system? Let us know if you have new issues

@LauraErhard
Copy link
Author

I just tested the deleting again.
If I delete two boxes and click save and exit I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again.
Similarly if I delete two boxes and click save I get the error again and it looks like both boxes were deleted, but if I go back with cancel only one box got deleted.
So there is still an issue or where @chah3d changes not yet implemented

@LauraErhard
Copy link
Author

@abdelqader-mohammad the scan view was the major change in the dev system right?
I linked a few different references and everything seems in order. The issues #437, #442, #439 are still there, but I think there was nothing done on them, so logically they still exist.
Are there any other particular changes I forgot about?

@abdelqader-mohammad
Copy link

@LauraErhard For issue #442, we fixed the problem of duplicated forms. The error that still exists needs action from the backend.
For #437 and #439 I want to check them. Maybe @chah3d or @lgalke have a fast comment for those issues.

@lgalke
Copy link
Member

lgalke commented Feb 14, 2019

it looks like it was deleted anyway. But after refreshing the page I see the box again.

We need to make sure that we update the view only if the back-end call succeeded. Maybe this is not properly reflected in this case.

@abdelqader-mohammad I've put my fast comments in the other issues.

@abdelqader-mohammad
Copy link

@lgalke Thank you for your comments :)
So, the mentioned issues need action from the other partners.

@chah3d
Copy link
Collaborator

chah3d commented Feb 19, 2019

I just tested the deleting again.
If I delete two boxes and click save and exit I get the error 500 for the second box again, but after clicking okay it looks like it was deleted anyway. But after refreshing the page I see the box again.
Similarly if I delete two boxes and click save I get the error again and it looks like both boxes were deleted, but if I go back with cancel only one box got deleted.
So there is still an issue or where @chah3d changes not yet implemented

The changes regarding the bounding box editing are now on the dev.

@abdelqader-mohammad
Copy link

I tried to delete 3 boxes. It works well.
@LauraErhard please test it

@LauraErhard
Copy link
Author

I can confirm, the deleting runs smoothly now. Thanks everyone!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants