-
Notifications
You must be signed in to change notification settings - Fork 442
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Z handling to LineSegment and Densifier #658
base: master
Are you sure you want to change the base?
Conversation
This is certainly a very thorough PR. However, I am not sure that An alternative is to implement new Also, |
I know JTS is a 2D library by design and z (or m) values will always have a place appart, |
My main concern is changing behaviour of I'm not so concerned about Densifier. Although I suspect that Densifier is mostly used to alleviate problems with algorithms which are themselves 2D only, and hence using the Z value might also produce unanticipated results. E.g. one use for Densifier is to allow long line segments to "bend" during reprojection - and reprojection is 2D only, typically. |
Take care of z ordinate in LineSegment. Also benefits Densifier which can now interpolate z values. A hasZ() method has been added in different coordinates implementation : it is not strictly needed but is more readable than cryptic Double.isNaN(d)