Skip to content

Commit

Permalink
allow the HOEDOWN_EXT_UNDERLINE to work
Browse files Browse the repository at this point in the history
When the `HOEDOWN_EXT_UNDERLINE` extension was enabled, underlined spans
would actually be passed verbatim to the output buffer. This was because
the active_char was _only_ set when the emphasis, double_emphasis, or
triple_emphasis handlers were registered. As a result, no active char
was found in the input buffer, so everything was passed through
verbatim.

This patch fixes this by also registering the `active_char` if the
underline handler is registered. I also added a simple regression test.

I personally don't use this extension, but I encountered this bug over
the course of writing bindings for Rust.
  • Loading branch information
blaenk committed Jan 31, 2015
1 parent fd09d02 commit 9b789d2
Show file tree
Hide file tree
Showing 4 changed files with 8 additions and 1 deletion.
2 changes: 1 addition & 1 deletion src/document.c
Original file line number Diff line number Diff line change
Expand Up @@ -2751,7 +2751,7 @@ hoedown_document_new(

memset(doc->active_char, 0x0, 256);

if (doc->md.emphasis || doc->md.double_emphasis || doc->md.triple_emphasis) {
if (doc->md.emphasis || doc->md.double_emphasis || doc->md.triple_emphasis || doc->md.underline) {
doc->active_char['*'] = MD_CHAR_EMPHASIS;
doc->active_char['_'] = MD_CHAR_EMPHASIS;
if (extensions & HOEDOWN_EXT_STRIKETHROUGH)
Expand Down
1 change: 1 addition & 0 deletions test/Tests/Underline.html
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
<p>This <u>underline</u> will work.</p>
1 change: 1 addition & 0 deletions test/Tests/Underline.text
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
This _underline_ will work.
5 changes: 5 additions & 0 deletions test/config.json
Original file line number Diff line number Diff line change
Expand Up @@ -101,6 +101,11 @@
"input": "Tests/Math.text",
"output": "Tests/Math.html",
"flags": ["--math"]
},
{
"input": "Tests/Underline.text",
"output": "Tests/Underline.html",
"flags": ["--underline"]
}
]
}

0 comments on commit 9b789d2

Please sign in to comment.