suppress repack commands' error message #1593
Open
+30
−8
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tangxifan
requested changes
Mar 8, 2024
tangxifan
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@treelin611 Good work. Can you add a testcase? Then it should be ready to merge. Thanks for the contribution.
|
|
||
| .. option:: --reduce_error_to_warning | ||
|
|
||
| Reduce error to warning while reading commands in pcf file |
There was a problem hiding this comment.
Add a warning message to alert users that they should be very cautious when enable this option.
See an example here: https://docs.verilogtorouting.org/en/latest/vpr/command_line_usage/#cmdoption-vpr-strict_checks
libs/libpcf/src/io/pcf_reader.cpp
Outdated
| break; // and move onto next line. without this, it will accept more | ||
| // following values on this line | ||
| if (reduce_error_to_warning) { | ||
| VTR_LOG_WARN("Unknown command '%s'!\n", word.c_str()); |
There was a problem hiding this comment.
Rephrase the message:
Bypass unknown command '%s'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Arkangel, the repack_dc file can be automatically generated from commands such as "set_clk" and "set_reset" in the PCF file. Therefore, some modifications are made in this PR to suppress the error messages for these two commands while reading pcf file.