Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preserve escaped names #1589

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

alaindargelas
Copy link

@alaindargelas alaindargelas commented Mar 4, 2024

Motivate of the pull request

  • [ x] To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

When writing out the Verilog testbench, openfpga writes illegal Verilog of the port identifiers coming from Yosys were originally escaped names, ie $iopadmap$a .
Yosys creates those escaped names when using the iopad pass.

What does this pull request change?

Restore the escaped names when necessary.

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • [ X] OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

@alaindargelas
Copy link
Author

@tangxifan, @ganeshgore , please authorize my workflow run.

@alaindargelas
Copy link
Author

alaindargelas commented Mar 5, 2024

@ganeshgore, @chungshien , how to run the code formatter for this repo?
There is no instructions I can find.

@chungshien-chai
Copy link
Contributor

@ganeshgore, @chungshien , how to run the code formatter for this repo? There is no instructions I can find.

This is OpenFPGA repo right? You can do this "make format-all"

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants