Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update FindTBB.cmake #1161

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Conversation

zaidtahirbutt
Copy link

@zaidtahirbutt zaidtahirbutt commented May 10, 2023

Replaced line 187 "file(READ "${TBB_INCLUDE_DIRS}/tbb/tbb_stddef.h" _tbb_version_file)" with "file(READ "/usr/include/oneapi/tbb/version.h" _tbb_version_file)" since latest version of tbb does not contain the file "tbb_stddef.h" which causes errors and failure in compilation of OpenFPGA. Replacing with this line solved the issue and OpenFPGA was compiled on Ubuntu 22.04.

Motivate of the pull request

  • To address an existing issue. If so, please provide a link to the issue:
  • Breaking new feature. If so, please describe details in the description part.

Describe the technical details

What is currently done? (Provide issue link if applicable)

What does this pull request change?

Which part of the code base require a change

  • VPR
  • Tileable routing architecture generator
  • OpenFPGA libraries
  • FPGA-Verilog
  • FPGA-Bitstream
  • FPGA-SDC
  • FPGA-SPICE
  • Flow scripts
  • Architecture library
  • Cell library
  • Documentation
  • Regression tests
  • Continous Integration (CI) scripts

Impact of the pull request

  • Require a change on Quality of Results (QoR)
  • Break back-compatibility. If so, please list who may be influenced.

Replaced line 187 "file(READ "${TBB_INCLUDE_DIRS}/tbb/tbb_stddef.h" _tbb_version_file)" with "file(READ "/usr/include/oneapi/tbb/version.h" _tbb_version_file)" since latest version of tbb does not contain the file "tbb_stddef.h" which causes errors and failure in compilation of OpenFPGA. Replacing with this line solved the issue and OpenFPGA was compiled on Ubuntu 22.04.
@zaidtahirbutt
Copy link
Author

Replaced line 187 "file(READ "${TBB_INCLUDE_DIRS}/tbb/tbb_stddef.h" _tbb_version_file)" with "file(READ "/usr/include/oneapi/tbb/version.h" _tbb_version_file)" since latest version of tbb does not contain the file "tbb_stddef.h" which causes errors and failure in compilation of OpenFPGA. Replacing with this line solved the issue and OpenFPGA was compiled on Ubuntu 22.04

@tangxifan
Copy link
Collaborator

@zaidtahirbutt I am actually looking for a general purpose CMake module to find TBB packages, such as

As we plan to support multiple OS platforms (as stated in #905), I suggest to avoid fixed paths when spotting TBB packages.

Let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants